Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency among different clients on when to use a specific diconnect reason #221

Open
smartprogrammer93 opened this issue Jan 27, 2023 · 1 comment

Comments

@smartprogrammer93
Copy link

As an example to this, when Geth disconnects a peer with a different network id with diconnection reason 0x10 (Other), whereas Nethermind disconnects a peer with a different network id with disconnection reason 0x03 (Useless Peer).

Because of this we are not able to know if the reason is NetworkId,or forkId for example. I think we need to relock at the disconnection reasons and work on a list that covers all cases.

if changing or adding to these messages is not an option or adding to then maybe we can come up with way for clients to send a details message explaining the reason for disconnection

@fjl
Copy link
Collaborator

fjl commented Jan 31, 2023

We can definitely clarify the situations in which those reasons should be returned. If you feel like certain reasons should be there, just send a pull request to update the spec in rlpx.md. This kind of change does not require a version update as long as we don't break backwards-compatibility too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants