Cleanup of disconnection reasons #5221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubo
approved these changes
Jan 30, 2023
asdacap
reviewed
Jan 30, 2023
| NdmInvalidHiSignature = 0x13, | ||
| NdmHostAddressesNotConfigured = 0x14, | ||
| NdmPeerAddressesNotConfigured = 0x15 | ||
| Other = 0x10 |
There was a problem hiding this comment.
If I'm not mistaken, for geth 0x10 is breach of protocol.
There was a problem hiding this comment.
So... probably fix that also.
There was a problem hiding this comment.
Yeah its. Its a lot of things afaik
There was a problem hiding this comment.
Nah, i would stick to the spec
There was a problem hiding this comment.
We can call it subprotocol but that isnt that clear. Idk
MarekM25
reviewed
Jan 30, 2023
src/Nethermind/Nethermind.Network/P2P/Messages/DisconnectMessageSerializer.cs
Show resolved
Hide resolved
MarekM25
approved these changes
Jan 31, 2023
MarekM25
reviewed
Jan 31, 2023
| @@ -14,9 +14,10 @@ public byte[] Serialize(DisconnectMessage msg) | |||
| { | |||
| return Rlp.Encode( | |||
| Rlp.Encode((byte)msg.Reason) // sic!, as a list of 1 element | |||
| ).Bytes; | |||
| ).Bytes; // we are not encoding the details as it is not part of the spec. but maybe it will be in the future. | |||
There was a problem hiding this comment.
I guess, this comment should be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Remarks
Breach was discussed with tomasz and he said that some peers used to send that instead of disconnection reason. I believe it is not important any longer and can be removed. also in the case that devp2p issue i posted here gets traction:
ethereum/devp2p#221
we might need to add more disconnection reasons that might use the same numbers as the ones i am removing.