Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p effort consolidation #59

Closed
FrankSzendzielarz opened this issue Feb 28, 2019 · 3 comments
Closed

p2p effort consolidation #59

FrankSzendzielarz opened this issue Feb 28, 2019 · 3 comments

Comments

@FrankSzendzielarz
Copy link
Member

It is becoming difficult to track the different p2p efforts.

We now seem to have many different groups working on devp2p wire protocols in different repos.

Some people working on eth2 p2p:
https://github.com/ethresearch/p2p/issues

General repo intended to be everything ethereum p2p:
https://github.com/ethereum/devp2p/

Discovery protocol for all future versions:
https://github.com/ethereum/devp2p/tree/master/discv5

Another group of people working on eth2.0 p2p:
ethereum/consensus-specs#692

There are also now multiple proposed wire formats for different places. RLP, SSZ, SOS, SSS, each with differing types of design goals and differing clarity in design goals.

Recent convo with @felix Lange (fjl) we agreed that ethereum/devp2p should be the label for 'all things p2p' in Ethereum. Do we agree with that , and if so, I would like to kick off some effort to consolidate and focus these groups- eg: by moving the different draft specs under ethereum/devp2p and having all the stakeholders converse there.

@Mikerah
Copy link
Contributor

Mikerah commented Feb 28, 2019

This may seem irrelevant but still using the term devp2p is outdated considering that the networking stack is going to be libp2p. Moreover, as people are confused between the differences between the 2, I think a consistent renaming should be done.

As for what repo to use, the whole purpose of https://github.com/ethresearch/p2p/issues was for discussions and ideas. Anything concrete like the wire protocol was meant to be an issue in the eth2.0-specs repo. If ethereum/devp2p become the repo for all things p2p in Ethereum, would it also include these discussions?

@fjl
Copy link
Collaborator

fjl commented Feb 28, 2019

We discussed this in the last eth2.0 implementers call and nobody spoke up against transferring p2p discussions here. So I guess we'll just do it.

I'll see how the repo can be reorganized to avoid confusion between eth1.0 and eth2.0.

@fjl
Copy link
Collaborator

fjl commented Apr 10, 2019

It looks like nobody is using https://github.com/ethresearch/p2p anymore. eth 2.0 networking discussion seems to be happening in the eth2.0-specs tracker now. See the networking label there.

@fjl fjl closed this as completed Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants