-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown lint to ensure inline solidity with a SPDX-License-Identifier
has a license of CC0.
#11
Comments
@SamWilsn could you let me know if this has been fixed or not ? and if not could you please provide and error example. Thank You ! |
There's a PR open to add this already: ethereum/EIPs#5379 |
Thanks @Pandapip1 I will talk to @SamWilsn in order to close all issues fixed already. |
@Pandapip1 does that license checker check code fence blocks inside of EIPs themselves? For some reason I thought it only checked This ticket is to generate a diagnostic message for code blocks within the EIP itself. For example: ## Abstract
...
## Specification
All compliant tokens MUST implement:
```solidity
// SPDX-License-Identifier: MIT
interface FooToken {
// ...
}
```
## Rationale
... |
This is accurate. You're right; eipw should lint EIPs to check for SPDX identifiers that are not CC0-1.0. |
Superseded by license checker CI. |
Hi, could you please let me know if this issue has been solved or not ? Ty. |
For inline as well? |
Yup, it detects inline SPDX headers. |
Sam, If this is it, so the issue should be closed. !? Ty. |
This ticket is to generate a diagnostic message for code blocks within the EIP itself. For example, this should generate an error:
The text was updated successfully, but these errors were encountered: