Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown lint to ensure inline solidity with a SPDX-License-Identifier has a license of CC0. #11

Open
SamWilsn opened this issue Jul 15, 2022 · 10 comments
Labels
good first issue Good for newcomers ready to implement Feature has reached rough consensus among editors and is ready to be implemented

Comments

@SamWilsn
Copy link
Contributor

SamWilsn commented Jul 15, 2022

This ticket is to generate a diagnostic message for code blocks within the EIP itself. For example, this should generate an error:

## Abstract

...

## Specification

All compliant tokens MUST implement:

```solidity
// SPDX-License-Identifier: MIT

interface FooToken {
    // ...
}
```

## Rationale

...
@SamWilsn SamWilsn added the good first issue Good for newcomers label Jul 15, 2022
@SamWilsn SamWilsn added the ready to implement Feature has reached rough consensus among editors and is ready to be implemented label Aug 18, 2022
@JEAlfonsoP
Copy link
Contributor

@SamWilsn could you let me know if this has been fixed or not ? and if not could you please provide and error example. Thank You !

@Pandapip1
Copy link
Member

There's a PR open to add this already: ethereum/EIPs#5379

@JEAlfonsoP
Copy link
Contributor

Thanks @Pandapip1 I will talk to @SamWilsn in order to close all issues fixed already.

@SamWilsn
Copy link
Contributor Author

@Pandapip1 does that license checker check code fence blocks inside of EIPs themselves? For some reason I thought it only checked *.sol files in the assets directory.

This ticket is to generate a diagnostic message for code blocks within the EIP itself. For example:

## Abstract

...

## Specification

All compliant tokens MUST implement:

```solidity
// SPDX-License-Identifier: MIT

interface FooToken {
    // ...
}
```

## Rationale

...

@Pandapip1
Copy link
Member

This is accurate. You're right; eipw should lint EIPs to check for SPDX identifiers that are not CC0-1.0.

@Pandapip1
Copy link
Member

Superseded by license checker CI.

@JEAlfonsoP
Copy link
Contributor

Hi, could you please let me know if this issue has been solved or not ? Ty.

@SamWilsn
Copy link
Contributor Author

Superseded by license checker CI.

For inline as well?

@Pandapip1
Copy link
Member

For inline as well?

Yup, it detects inline SPDX headers.

@JEAlfonsoP
Copy link
Contributor

JEAlfonsoP commented Apr 25, 2023

Sam, If this is it, so the issue should be closed. !? Ty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ready to implement Feature has reached rough consensus among editors and is ready to be implemented
Projects
None yet
Development

No branches or pull requests

3 participants