-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lint preventing EIP references in backticks #90
Comments
@SamWilsn I'd like to work on this. |
Done! Be aware that we need to be careful to allow things like |
Noted! |
@SamWilsn I would love to work on this repo. Could you please assign me? |
@Hari-Bombon we should give the user above a chance to work on this, since she asked first. #11 or #5 might be good candidates to try instead? |
Hi @SamWilsn, I have added the lint rule but my test keeps failing. |
@VictoriaAde I'd need to see a bit more of your code (do you have a branch somewhere?) but if I had to guess, it looks like your |
@SamWilsn I looked at what you said and now if I run cargo run or test, it will giving the below message. |
Right, forgot about that. The project is divided into a few crates (aka packages):
To run the tests for lints, you'll need to change directory into cd eipw-lint
cargo test Alternatively, you can run all the tests from the root directory: cargo test --all Regarding the cargo run -- ~/EIPs/EIPS/eip-3074.md |
Oh my, thank you so much. |
@SamWilsn, I made a PR, please check it out |
Many authors attempt to circumvent the EIP link requirements by putting EIP-XXXX in backticks (eg. `EIP-1234`.) This is bad form, and should be rejected.
The text was updated successfully, but these errors were encountered: