Merge in project template #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise tox fails, and the auto-lint never runs
Add docstring checking with pydocstyle
Remove attribution to specific person, update README
Remove travis config
Update default author email
…ve-pypy-markdown-support switch to native pypy markdown support
Skip venv in template filler & print progress
Add MANIFEST.in file
carver
force-pushed
the
upgrade-template
branch
from
57be5be to
b312793
Compare
Later, when the template upgrades, it will be easier to merge the changes in to this repo now. See: https://github.com/ethereum/snake-charmers-tactical-manual/blob/master/template.md
carver
force-pushed
the
upgrade-template
branch
from
3f347db to
5154468
Compare
fselmo
pushed a commit
to fselmo/eth-abi
that referenced
this pull request
Apr 4, 2022
(cherry picked from commit 139e545)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The project didn't include a lot of the nice tools we have in the template, like towncrier for release notes, and the latest release makefile targets.
In fact, the template had never been merged in.
How was it fixed?
Merged in the template, and dealt with all the conflicts, for easier upgrades in the future.
TODO:
Cute Animal Picture