Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
A version bump failed, that's weird:
https://travis-ci.org/ethereum/eth-abi/jobs/337782324
Even weirder, a travis test on the same commit succeeded:
https://travis-ci.org/ethereum/eth-abi/jobs/337782341
Oh, it's a hypothesis test, so we had to get lucky on finding the example. Turns out the failure was related to building the expected value in the test, not in the project source.
How was it fixed?
decimal.Context
definitionDecimal
usages to put them in theabi_decimal_context
Cute Animal Picture