-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made eth-abi a primary dependency #127
Conversation
d1a8784
to
9b0b082
Compare
Just to explicitly state the implicit change: this treats eth-tester like an end product rather than a library. (by forcing a choice of eth-hash backend, for example) I think this is reasonable, just wanted to make sure everyone is one the same page. |
@carver My reasoning is as follows:
Although a user has the freedom to explicitly install any |
I encountered this in voith/eth-tester-rpc#10 |
That's a good point, the |
@carver I had thought about using Probably, I should have fixed the |
What was wrong?
eth-tester
would give the following error:This was missed in #115 (4073ee2).
This wasn't detected by tests because
eth-abi
was testing dependencyHow was it fixed?
eth-abi
was removed as a testing dependency and was made a primary dependency.Bonus changes
pycryptodome
orpysha3
are optional dependencies ofpy-evm
that are needed foreth-tester
to work. Install them based on the python implementation available. (Haven't tested it with pypy manually, I'm relying on tests to tell me).PS: I have added all these in separate commits to keep unrelated changes isolated.
Cute Animal Picture