Make gas limit constant #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oof, interesting, it force-closed this on the force-push with a typo, but then won't let me fix it. I can't reopen the PR or push the correct branch. Sorry about that. Obviously the commits will still be attributed to you. I'll reopen in a sec, in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fixes #186
The gas limit changed because of py-evm backend
How was it fixed?
By overriding the header creation function to just copy the gas limit from the parent.
Let me know if this was the correct place to add the tests.
I did not know why
validate_sealwas added as@classmethod, so maybe you want that for create_header_from_parent` too.Also, this might be a breaking change for folks that rely on that behavior (one test here also expected that behavior). Another option would be to make it somehow configurable, but that would be more work. I think the default should be constant gas limit.