Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3.is_address no longer requires checksummed addresses #265

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented Feb 20, 2024

What was wrong?

Relates to ethereum/web3.py#715
Closes #246

How was it fixed?

Removed validation of checksummed addresses from the Web3.is_address utility.

Todo:

  • Clean up commit history

  • Add or update documentation related to these changes

  • Add entry to the release notes

Cute Animal Picture

Screen Shot 2024-02-20 at 10 51 50 AM

reedsa added a commit to reedsa/eth-utils that referenced this pull request Feb 20, 2024
Copy link
Contributor

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@reedsa reedsa merged commit b57da60 into ethereum:main Feb 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update is_address logic
3 participants