Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc fixes from cpp-ethereum repo. #110

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

hackmod
Copy link

@hackmod hackmod commented Nov 22, 2018

mancoast and others added 7 commits November 22, 2018 20:00
This improves performance using 512bit SIMD instructions.
It looks like older versions of GCC have slightly unreliable logic for array out-of-bounds detection.
Code in ethash which uses unions and arrays is firing a warning in both Debian Jesse (8.5) and in the ARM Linux cross-builds.
Debian Jesse uses GCC 4.9.2.   The cross-builds are using GCC 4.8.4.
Other distros are using GCC 5.x or even GCC 6.x (Arch).
The issue is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56273 and was fixed in GCC 5.0 and backported to 4.9.3.

Updated comments.
With this change we will be able to remove a global warning suppression from our CMake files.
@hackmod hackmod mentioned this pull request Nov 25, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants