Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python extension for Windows #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Python extension for Windows #79

wants to merge 2 commits into from

Conversation

chfast
Copy link
Member

@chfast chfast commented Jan 12, 2016

No description provided.

MinGW GCC compiler is needed to build Python extension for Windows. Visual Studio for Python 2.7 cannot handle C99 standard.
This change allows building binary distribution of the Python package (wheel).
@LefterisJP
Copy link
Contributor

I don't see anything wrong with adding this.
But since ethash is used by Go team too let's have @obscuren take a look too.

Also maybe polluting io_win32.c file with #ifndef can be avoided by moving the mingw detection at build time and compiling io_posix.c instead?

@chfast
Copy link
Member Author

chfast commented Jan 29, 2016

I will try that, but usually problem with mingw is that it is none and both of Win32 and GCC in the same time.

In other words mingw is not POSIX. But I will check what can be done.

@LefterisJP
Copy link
Contributor

@chfast yes I understand. I have not tried it myself so if it can be improved that's good. If not then no problem from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants