Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report (Two broken links) #10972

Closed
1 of 2 tasks
Omsify opened this issue Aug 20, 2023 · 3 comments · Fixed by #10981 or #11143
Closed
1 of 2 tasks

Bug report (Two broken links) #10972

Omsify opened this issue Aug 20, 2023 · 3 comments · Fixed by #10981 or #11143
Labels
bug 🐛 Something isn't working needs triage 📥 This issue needs triaged before being worked on

Comments

@Omsify
Copy link

Omsify commented Aug 20, 2023

Describe the bug

Two links on the block proposal are broken. (PREREQUISITES section)

Block proposal is part of the proof-of-stake protocol. To help understand this page, we recommend you read about [proof-of-stake](src/content/developers/docs/consensus-mechanisms/pos/) and [block architecture](src/content/developers/docs/blocks/).

To reproduce

  1. Go to 'block proposal page'
  2. Scroll down to 'PREREQUISITES section'
  3. Click on 'any of the links in the PREREQUISITES section'
  4. See error

Expected behavior

A correct page should open

Screenshots

No response

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@Omsify Omsify added the bug 🐛 Something isn't working label Aug 20, 2023
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Aug 20, 2023
@Omsify
Copy link
Author

Omsify commented Aug 20, 2023

Seems that these links forward me to a strange URL:
https://ethereum.org/ensrc/content/developers/docs/consensus-mechanisms/pos/
Notice the ensrc not being separated with a slash here.

kritik-sah added a commit to kritik-sah/ethereum-org-website that referenced this issue Aug 23, 2023
corwintines added a commit that referenced this issue Sep 6, 2023
@corwintines
Copy link
Member

Apologies for missing this issue when reviewing @Omsify and not assigning it to you. I really appreciate you calling this out and creating this issue. Will try and be more on top of this in the future and assingn to you for the PR.

@all-contributors can you add @Omsify for bug

@allcontributors
Copy link
Contributor

@corwintines

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @Omsify! 🎉

This was referenced Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working needs triage 📥 This issue needs triaged before being worked on
Projects
None yet
2 participants