Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug report: Refactoring by using The Nullish Coalescing Operator (??) in settings files #12057

Closed
1 of 2 tasks
HiroyukiNaito opened this issue Jan 30, 2024 · 1 comment · Fixed by #12058
Closed
1 of 2 tasks

Bug report: Refactoring by using The Nullish Coalescing Operator (??) in settings files #12057

HiroyukiNaito opened this issue Jan 30, 2024 · 1 comment · Fixed by #12058
Labels
bug 🐛 Something isn't working

Comments

@HiroyukiNaito
Copy link
Contributor

HiroyukiNaito commented Jan 30, 2024 •
edited
Loading

Describe the bug

Using Nullish Coalescing Operator in the settings files is safer coding.
But, it is a minimal improvement.

To reproduce

none

Expected behavior

none

Screenshots

No response

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@HiroyukiNaito HiroyukiNaito added the bug 🐛 Something isn't working label Jan 30, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jan 30, 2024
HiroyukiNaito added a commit to HiroyukiNaito/ethereum-org-website that referenced this issue Jan 30, 2024
@HiroyukiNaito
Change operator || to ?? where reading environmental valuable [Fixes
09764f5 
 ethereum#12057]
@HiroyukiNaito HiroyukiNaito mentioned this issue Jan 30, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Mar 16, 2024
wackerow added a commit that referenced this issue May 7, 2024
@wackerow
Merge pull request #12058 from HiroyukiNaito/01302024_2
65357cb 
Change operator `||` to `??` where reading environmental valuable  [Fixes #12057]
This was referenced May 8, 2024
Merged
Merged
@wackerow wackerow removed Status: Stale This issue is stale because it has been open 30 days with no activity. needs triage 📥 This issue needs triaged before being worked on labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@HiroyukiNaito @wackerow