Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing auto-linked headers on glossary page #12393

Closed
1 of 2 tasks
wackerow opened this issue Mar 7, 2024 · 5 comments
Closed
1 of 2 tasks

Missing auto-linked headers on glossary page #12393

wackerow opened this issue Mar 7, 2024 · 5 comments
Assignees
Labels
bug 🐛 Something isn't working dev required This requires developer resources help wanted Extra attention is needed or someone is needed to help low priority This has a low priority Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@wackerow
Copy link
Member

wackerow commented Mar 7, 2024

Describe the bug

The glossary page was previously entirely markdown, which had custom header IDs for each glossary entry header, ie ### Account {#account}. This has been converted to using a custom component for each term entry, ie <GlossaryDefinition term="account" />.

This component renders a header that does contain an id (ie. <h3 ... id="account">), but does not include the auto-linking (link to self) like the section headers do.

To reproduce

  1. Go to https://ethereum.org/en/glossary/
  2. Hover over "A", and notice the link icon that appears, which contains a link to itself
  3. Hover over a glossary term such as "Account", and notice this does not contain a link to itself

Expected behavior

All headers on this page should have an auto-link to the ID of that section, including a hover effect to quickly access this link.

Screenshots

image

When hovering over "A"... but this does not occur when hovering over "Account"

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@wackerow wackerow added the bug 🐛 Something isn't working label Mar 7, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Mar 7, 2024
@wackerow wackerow added low priority This has a low priority dev required This requires developer resources help wanted Extra attention is needed or someone is needed to help and removed needs triage 📥 This issue needs triaged before being worked on labels Mar 7, 2024
@korbinschulz
Copy link

I'd like to take this issue. Went through the repo and found how the glossary sections have their links set up and viewed the GlossaryDefinition component, so I believe I'd just essentially do the same thing there.

@resourcefulmind
Copy link

Hi there chief!

I've noticed the missing auto-link headers on the glossary page, and I'd like to jump in and help fix that. I'm familiar with React and front-end development, so I think I could tackle this issue.
Could you point me to the component or area of the codebase where this needs to be addressed?

Excited to contribute to improving the site's UX!

@wackerow
Copy link
Member Author

Thanks @korbinschulz and @resourcefulmind for offering to help! Sorry for delay, looks like @checkomkar has a PR up that could solve this already, so going to assign to avoid redundant work. Feel free to check out that solution and add to the discussion

@wackerow
Copy link
Member Author

Hm, actually I can't seem to assign @checkomkar, but the PR is linked... can come back after that is reviewed if more help needed.

@wackerow wackerow self-assigned this Apr 1, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 7, 2024
This was referenced Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working dev required This requires developer resources help wanted Extra attention is needed or someone is needed to help low priority This has a low priority Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

No branches or pull requests

3 participants