Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: outline on mobile glossary tooltip #12597

Closed
1 of 2 tasks
Tracked by #12399
wackerow opened this issue Mar 28, 2024 · 5 comments
Closed
1 of 2 tasks
Tracked by #12399

Bug report: outline on mobile glossary tooltip #12597

wackerow opened this issue Mar 28, 2024 · 5 comments
Assignees
Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing low priority This has a low priority

Comments

@wackerow
Copy link
Member

Describe the bug

GlossaryTooltip component displaying an outline when used on mobile; not present on desktop

To reproduce

  1. Use a phone
  2. Go to https://ethereum.org/en/nft
  3. Click on dotted-underlined "blockchain" at the end of the second paragraph
  4. Notice colored outline to the tooltip box

Expected behavior

No outline; should appear same as on desktop

Screenshots

image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

iPhone, Brave or Safari

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@wackerow wackerow added the bug 🐛 Something isn't working label Mar 28, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Mar 28, 2024
@rileyannon
Copy link
Contributor

Is this claimed yet?
I was taking a look through some of the docs and I found that this may be linked to ChakraUI as shown in this issue: chakra-ui/chakra-ui#708

I'd like to take a stab at it - not yet sure how I could run this locally on mobile (I'm a n00b) but I'm interested!

@wackerow wackerow added low priority This has a low priority good first issue Good item to try if you're new to contributing and removed needs triage 📥 This issue needs triaged before being worked on labels Apr 1, 2024
@wackerow
Copy link
Member Author

wackerow commented Apr 1, 2024

Thanks @rileyannon!


If you use VSCode, you could try their "Ports" feature to view localhost on mobile... Fire up the server, then go to the "Ports" tab near your Terminal (may need to be signed in using GitHub account):

image

Click "Forward a Port", type in "3000" (assuming your server is on that port), and hit Enter. Give it a moment and it should display an address that you can copy, and then use that from your phone. If set to "Private" (default), you'll need to login with GitHub on your phone as well; if "Public" then anyone can view that... it's a slow tunnel, but it'll feed your localhost:3000 to that address.


If you don't use VSCode, I'm sure there are other solutions but I'd say you can always just publish a branch as a PR and a Netlify preview deploy will be built that you can use:

image

It'll show up in a comment on your PR like this

@rileyannon
Copy link
Contributor

Thanks for the walkthrough @wackerow! Glad to finally know how that works :)

Copy link
Contributor

github-actions bot commented May 7, 2024

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 7, 2024
@SeanXLChen
Copy link
Contributor

Hi, I could take this one.

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 9, 2024
corwintines added a commit that referenced this issue May 22, 2024
fix: override box-shadow to none to avoid tooltip border #12597
This was referenced May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing low priority This has a low priority
Projects
None yet
Development

No branches or pull requests

3 participants