Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate use of postMergeBannerTranslation #12637

Closed
4 tasks
wackerow opened this issue Apr 2, 2024 · 2 comments · Fixed by #12768
Closed
4 tasks

Deprecate use of postMergeBannerTranslation #12637

wackerow opened this issue Apr 2, 2024 · 2 comments · Fixed by #12768
Assignees
@colmck
Labels
dev required This requires developer resources good first issue Good item to try if you're new to contributing low priority This has a low priority

Comments

@wackerow
Copy link
Member

wackerow commented Apr 2, 2024 •
edited
Loading

Issue

The "post merge banner" and logic/strings surrounding it are no longer needed.

Currently the postMergeBannerTranslation front matter property is only being used on one page (in all languages), public/content/governance/index.md (/governance/ path). This file uses the Static layout, which does not actually handle this variable.

Meanwhile, we do handle it in the Tutorial layout, but no tutorials have this property anymore.

Scope
Preview Give feedback
@wackerow wackerow added low priority This has a low priority good first issue Good item to try if you're new to contributing dev required This requires developer resources labels Apr 2, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Apr 2, 2024
@colmck
Copy link

colmck commented Apr 2, 2024

I'd like to take this on if that's alright!

colmck added a commit to colmck/ethereum-org-website that referenced this issue Apr 3, 2024
@colmck
Deprecated postMergeBannerTranslation [Fixes ethereum#12637]
8640b2c
@wackerow
Copy link
Member Author

wackerow commented Apr 8, 2024

Great, thanks @colmck, assigned you

@wackerow wackerow removed the needs triage 📥 This issue needs triaged before being worked on label Apr 8, 2024
@colmck colmck mentioned this issue Apr 9, 2024
Closed
selank1317 pushed a commit to colmck/ethereum-org-website that referenced this issue Apr 17, 2024
Deprecated PostMergeBanner [Fixes ethereum#12637]
27af3c4
@colmck colmck mentioned this issue Apr 17, 2024
Merged
wackerow added a commit that referenced this issue Apr 18, 2024
@wackerow
Merge pull request #12768 from colmck/deprecate
df72ece 
Deprecated PostMergeBanner [Fixes #12637]
This was referenced Apr 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colmck colmck

Labels
dev required This requires developer resources good first issue Good item to try if you're new to contributing low priority This has a low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecated PostMergeBanner [Fixes #12637] colmck/ethereum-org-website
2 participants
@wackerow @colmck