Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS Implementation - SkipNav #12929

Closed
TylerAPfledderer opened this issue May 8, 2024 · 27 comments
Closed

DS Implementation - SkipNav #12929

TylerAPfledderer opened this issue May 8, 2024 · 27 comments
Assignees
Labels
dev required This requires developer resources good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@TylerAPfledderer
Copy link
Contributor

TylerAPfledderer commented May 8, 2024

🚨As of the initial posting of this issue, a new design needs to be created in Figma by @nloureiro before executing this update. The issue can still be assigned by a contributor in the meantime.

Update the existing SkipNav component to use a new design.

Currently, this component is fully custom in it's styles and handling of the link redirect to content in the given page. Recommend investigating the use of the SkipNavLink and SkipNavContent provided by Chakra to handle in consideration of accessibility.

Be aware that SkipNavLink under the hood renders a primitive a tag with needed logic passed to it. We should retain this render, as its only job is to send the user to the specified section of content.

It also has it's own theme config SkipLink. See source code.

In summary of initial recommendations:

  • Remove the custom SkipLink file in favor of keeping styling in the component theme configuration
  • Any translated content and href can be supplied at the parent level RootLayout.
  • Import SkipNavLink / SkipNavContent directly from Chakra

cc @pettinarip Do NOT assign me! 😅

@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label May 8, 2024
@wackerow wackerow added help wanted Extra attention is needed or someone is needed to help dev required This requires developer resources design system this label will be used in all issues related to design system design required 🎨 This involves design changes and removed needs triage 📥 This issue needs triaged before being worked on labels May 9, 2024
@vibrant-boredom
Copy link

Could you assign me, please?

@Dharmik79
Copy link

@wackerow I want to work on this issue, once the Figma design is updated.

@nloureiro
Copy link
Contributor

@murluki are you able to do the Figma design proposal?

@vibrant-boredom
Copy link

@nloureiro yes, I can help you with this.

@nloureiro
Copy link
Contributor

@nloureiro yes, I can help you with this.

great! will you create a Figma file? or do you want me to create one.

@pettinarip
Copy link
Member

@murluki just to clarify, are you doing the design and the implementation in the code? or just the design part? assigning to you in the meantime.

@vibrant-boredom
Copy link

@nloureiro could you please create the Figma file?
@pettinarip I’ll be doing the front end coding part for this task.

@nloureiro
Copy link
Contributor

@nloureiro could you please create the Figma file? @pettinarip I’ll be doing the front end coding part for this task.

go for it!!!
https://www.figma.com/design/EecunGD6oTh62h7rdukaFL/Skip-Nav-component?node-id=1%3A49&t=lHyaiG0J1dR9xp0Q-1

Thank you for your collaboration

@TylerAPfledderer
Copy link
Contributor Author

@pettinarip @murluki I updated this issue's description to give better clarity in describing what Chakra's SkipNavLink renders.

@surajpsuresh
Copy link

Hi I would like to help out on this, is it possible to assign me also to this?

@vibrant-boredom
Copy link

@surajpsuresh Hi, I am actually done with it and will be pushing it tonight

@surajpsuresh
Copy link

Okay cool

@surajpsuresh
Copy link

@murluki Is it possible to talk to you regarding contributing, best practices and how to actually share design work on GitHub.
I have been looking at tutorials online, but would rally appreciate talking to an actual person on how to navigate in GitHub.

Any time that is convenient for you would work!

Cheers!

@vibrant-boredom
Copy link

@surajpsuresh of course, if you have telegram, hit me up at murluki_prg. I can share some tips with you :)

@surajpsuresh
Copy link

Done

@TylerAPfledderer
Copy link
Contributor Author

@murluki and @surajpsuresh you may reach out to me if you need any clarification of the requirements! 😁

@surajpsuresh
Copy link

@murluki and @surajpsuresh you may reach out to me if you need any clarification of the requirements! 😁

Sure @TylerAPfledderer will do, I guess @murluki has completed this for now, keeping an eye out for any new design tasks that may pop up.

@corwintines corwintines added the Status: Blocked 🛑 This is blocked label Jun 18, 2024
@corwintines
Copy link
Member

GM all!

I am trying to get caught up to speed on where we are at for this issue.

@nloureiro I can't access that Figma file that you linked out to here. Is this still available?

I put this as blocked for now, as it sounds like design is needed here first.

@nloureiro
Copy link
Contributor

GM all!

I am trying to get caught up to speed on where we are at for this issue.

@nloureiro I can't access that Figma file that you linked out to here. Is this still available?

I put this as blocked for now, as it sounds like design is needed here first.

sorry about this, the new draft mode from fig broke the old links.... damn!!!

here is the link:
https://www.figma.com/design/EecunGD6oTh62h7rdukaFL/Skip-Nav-component?node-id=1-49&t=G6bMA9l77bupwTjt-1

@corwintines corwintines removed the Status: Blocked 🛑 This is blocked label Jun 24, 2024
@corwintines
Copy link
Member

Thanks @nloureiro

It seems like what we have left here is implementation now that we can access design again.

@murluki do you have an update on where you are at with this? Do you have any questions?

@nloureiro nloureiro removed the design system this label will be used in all issues related to design system label Jul 2, 2024
@nloureiro nloureiro removed the design required 🎨 This involves design changes label Jul 2, 2024
Copy link
Contributor

github-actions bot commented Aug 2, 2024

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 2, 2024
@minimalsm
Copy link
Contributor

Hey @murluki, are you still looking to work on this?

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 21, 2024
@nloureiro nloureiro added the good first issue Good item to try if you're new to contributing label Sep 2, 2024
@Baystef
Copy link
Contributor

Baystef commented Sep 2, 2024

Hi @corwintines @minimalsm , I'll love to work on this. Thanks. Please assign to me

@minimalsm
Copy link
Contributor

Assigned @Baystef. Please note this should be implemented in Shadcn/Tailwind, not Chakra as the issue says. LMK if that's an issue, thanks again!

@Baystef
Copy link
Contributor

Baystef commented Sep 3, 2024

Assigned @Baystef. Please note this should be implemented in Shadcn/Tailwind, not Chakra as the issue says. LMK if that's an issue, thanks again!

It's not an Issue. Thanks

Copy link
Contributor

github-actions bot commented Oct 3, 2024

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Oct 3, 2024
corwintines added a commit that referenced this issue Oct 21, 2024
Implements skipnav link to match new design [#12929]
@corwintines
Copy link
Member

Closing with above PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev required This requires developer resources good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

No branches or pull requests

10 participants