Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solo staking page: Goerli has been deprecated; use Holesky #13168

Closed
1 of 2 tasks
wackerow opened this issue Jun 14, 2024 · 6 comments · Fixed by #13368
Closed
1 of 2 tasks

Solo staking page: Goerli has been deprecated; use Holesky #13168

wackerow opened this issue Jun 14, 2024 · 6 comments · Fixed by #13368
Assignees
@SnehalSrivastava27
Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help

Comments

@wackerow
Copy link
Member

Describe the bug

The /staking/solo page has a widget for users to get started with staking, but it is still pointing to the Goerli Launchpad. This should be updated to use the Holesky testnet Launchpad instead.

To reproduce

  1. Go to https://ethereum.org/en/staking/solo/#get-started-on-the-staking-launchpad
  2. Click on the dropdown for "Choose a network"
  3. See use of Goerli testnet, which has been deprecated.

Expected behavior

References to Goerli should be removed and replaced with the Holesky testnet where users can practice staking before going to Mainnet.

Screenshots

No response

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@wackerow wackerow added the bug 🐛 Something isn't working label Jun 14, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jun 14, 2024
@wackerow wackerow added help wanted Extra attention is needed or someone is needed to help good first issue Good item to try if you're new to contributing and removed needs triage 📥 This issue needs triaged before being worked on labels Jun 14, 2024
@SnehalSrivastava27
Copy link
Contributor

I would like to take this issue
Can I go ahead?

dbarabashh pushed a commit to dbarabashh/ethereum-org-website that referenced this issue Jun 17, 2024
update staking launchpad to use Holesky testnet [Fixes ethereum#13168]
6f5832c
@dbarabashh dbarabashh mentioned this issue Jun 17, 2024
Closed
@SnehalSrivastava27
Copy link
Contributor

@wackerow I have made all the required content and translation changes please check it out

@wackerow
Copy link
Member Author

@wackerow I have made all the required content and translation changes please check it out

Did you push them to #13184? Not seeing them

@SnehalSrivastava27
Copy link
Contributor

SnehalSrivastava27 commented Jun 18, 2024 •
edited
Loading

@wackerow i made a new pull request
#13187

dbarabashh added a commit to dbarabashh/ethereum-org-website that referenced this issue Jun 18, 2024
@dbarabashh
update text for translation [Fixes ethereum#13168]
7644021
@wackerow
Copy link
Member Author

Oh, apologies, getting confused with different authors. @SnehalSrivastava27 you were the first to request to work on the issue and would like to honor this. @tutizaraz appreciate the enthusiasm, but please make sure to comment on an issue an await being assigned before jumping straight to posting PRs to avoid conflict.

@dbarabashh
Copy link
Contributor

Sure @wackerow ! Good job @SnehalSrivastava27

This was referenced Jul 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SnehalSrivastava27 SnehalSrivastava27

Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help
Projects
None yet
Milestone
No milestone
3 participants
@dbarabashh @wackerow @SnehalSrivastava27