-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inappropriate padding in code blocks #13299
Comments
|
Hey @Baystef hah are you trying to say "Yes" you'd like to work on this? |
Great, thanks! Assigning =) |
Looping back, appreciate the patch @sandeepV2... @Baystef apologies for the override, mind if we re-assign and find another one for ya? Would check out the unassigned "good first issues" if you're interested! |
Sure, I'll look through and tag you to it |
Adds bottom padding to code block [Fixes #13299]
Describe the bug
The
Codeblock
component is used to render various types of code snippets from the triple-backtick markdown syntax (```). These blocks currently do not have appropriate padding applied to them.To reproduce
Expected behavior
Codeblocks should have 1.5rem padding-bottom applied to improve readability
Screenshots
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional context
Note that some codeblocks have a "copy" button added to it which alters the top padding; this should remain unchanged. The codeblocks without the copy button use
24px
(1.5rem
, size token6
) for the top padding; I would recommend we use the same for the bottom.Similarly, some code blocks are longer than others... there is a max-height applied initially, with a "Show all" button for longer blocks. In those cases, we do not need padding if there is more code to scroll to, but once we're at the bottom there should be padding.
Would you like to work on this issue?
The text was updated successfully, but these errors were encountered: