Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Image Paths in README.md #13308

Closed
1 of 2 tasks
Shiva-Sai-ssb opened this issue Jul 3, 2024 · 3 comments · Fixed by #13311 or #13368
Closed
1 of 2 tasks

Incorrect Image Paths in README.md #13308

Shiva-Sai-ssb opened this issue Jul 3, 2024 · 3 comments · Fixed by #13311 or #13368
Assignees
Labels
bug 🐛 Something isn't working

Comments

@Shiva-Sai-ssb
Copy link
Contributor

Describe the bug

The README.md file contains broken image links due to changes in file paths.

To reproduce

  1. Go to the README.md file on the main repository page.
  2. Locate the Ethereum logo, Netlify preview image, and POAP logo.
  3. Observe that these images are not displaying correctly.

Expected behavior

All images in the README.md file should display correctly with the updated file paths.

Screenshots

Pic-1

Pic-2

Pic-3

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

  1. The Ethereum logo path should be changed from ./public/assets/eth-transparent.png to ./public/images/assets/eth-transparent.png.

  2. The Netlify preview image path should be changed from public/preview-deploy.png to public/images/preview-deploy.png.

  3. The POAP logo path should be changed from public/poap-logo.svg to public/images/poap-logo.svg.

Moreover, only GitPOAP is given to contributors upon making their first pull request on merging it into the repo, while OATs are given to contributors for making significant contributions to the repo, including translations. I think it would be beneficial to replace the section specifically mentioning POAP with a section describing OATs instead.

Would you like to work on this issue?

  • Yes
  • No
@Shiva-Sai-ssb Shiva-Sai-ssb added the bug 🐛 Something isn't working label Jul 3, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jul 3, 2024
@wackerow wackerow self-assigned this Jul 3, 2024
@wackerow wackerow removed the needs triage 📥 This issue needs triaged before being worked on label Jul 3, 2024
@wackerow
Copy link
Member

wackerow commented Jul 3, 2024

Thanks for raising @Shiva-Sai-ssb! I've put up a patch for this

@wackerow
Copy link
Member

wackerow commented Jul 3, 2024

@all-contributors please add @Shiva-Sai-ssb for bug report

Copy link
Contributor

@wackerow

I've put up a pull request to add @Shiva-Sai-ssb! 🎉

corwintines added a commit that referenced this issue Jul 9, 2024
fix: image paths for README embeds [Fixes #13308]
This was referenced Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
2 participants