-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Image Paths in README.md #13308
Closed
1 of 2 tasks
Labels
bug 🐛
Something isn't working
Comments
github-actions
bot
added
the
needs triage 📥
This issue needs triaged before being worked on
label
Jul 3, 2024
wackerow
removed
the
needs triage 📥
This issue needs triaged before being worked on
label
Jul 3, 2024
Thanks for raising @Shiva-Sai-ssb! I've put up a patch for this |
@all-contributors please add @Shiva-Sai-ssb for bug report |
I've put up a pull request to add @Shiva-Sai-ssb! 🎉 |
corwintines
added a commit
that referenced
this issue
Jul 9, 2024
fix: image paths for README embeds [Fixes #13308]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The README.md file contains broken image links due to changes in file paths.
To reproduce
Expected behavior
All images in the README.md file should display correctly with the updated file paths.
Screenshots
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional context
The Ethereum logo path should be changed from
./public/assets/eth-transparent.png
to./public/images/assets/eth-transparent.png
.The Netlify preview image path should be changed from
public/preview-deploy.png
topublic/images/preview-deploy.png
.The POAP logo path should be changed from
public/poap-logo.svg
topublic/images/poap-logo.svg
.Moreover, only GitPOAP is given to contributors upon making their first pull request on merging it into the repo, while OATs are given to contributors for making significant contributions to the repo, including translations. I think it would be beneficial to replace the section specifically mentioning POAP with a section describing OATs instead.
Would you like to work on this issue?
The text was updated successfully, but these errors were encountered: