Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated eth_coinbase #13996

Closed
1 of 2 tasks
MaryNfs opened this issue Sep 29, 2024 · 2 comments · Fixed by #13997
Closed
1 of 2 tasks

Deprecated eth_coinbase #13996

MaryNfs opened this issue Sep 29, 2024 · 2 comments · Fixed by #13997
Assignees
Labels
bug 🐛 Something isn't working hacktoberfest Track hacktoberfest activity

Comments

@MaryNfs
Copy link
Contributor

MaryNfs commented Sep 29, 2024

Describe the bug

As per ethereum/go-ethereum#29747, eth_coinbase no longer returns an address in v1.14.0+.
Since this RPC method is deprecated, we should remove it from JSON-RPC API list.

To reproduce

We can see eth_coinbase in the RPC list.
https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_coinbase

Expected behavior

We should not list the unsupported RPC APIs.

Screenshots

No response

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

In Deploying a contract example, its been mentioned eth_coinbase for getting the coinbase address, instead we can call it as developer account and use eth_accounts to retrieve it.

Would you like to work on this issue?

  • Yes
  • No
@MaryNfs MaryNfs added the bug 🐛 Something isn't working label Sep 29, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Sep 29, 2024
@Jagadeeshftw
Copy link

Hi, I would like to work on this issue, can anyone assign it to me?

@MaryNfs
Copy link
Contributor Author

MaryNfs commented Oct 2, 2024

Hi, I would like to work on this issue, can anyone assign it to me?

Hi @Jagadeeshftw I have created the pr already, you can find it here.

@wackerow wackerow added hacktoberfest Track hacktoberfest activity and removed needs triage 📥 This issue needs triaged before being worked on labels Oct 2, 2024
wackerow added a commit that referenced this issue Oct 4, 2024
Removed deprecated eth_coinbase from json-rpc docs[#13996]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working hacktoberfest Track hacktoberfest activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants