Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info on smart contract size limit #3943

Closed
samajammin opened this issue Sep 18, 2021 · 9 comments
Closed

Add info on smart contract size limit #3943

samajammin opened this issue Sep 18, 2021 · 9 comments
Labels
content 🖋️ This involves copy additions or edits good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@samajammin
Copy link
Member

samajammin commented Sep 18, 2021

Is your feature request related to a problem? Please describe.

Currently we don't provide any info on this limitation.

Describe the solution you'd like

I think we should mention this contract size limitation (24KB) somewhere in our docs on smart contracts:
https://ethereum.org/en/developers/docs/smart-contracts/

We could also list approaches to getting around this limitation, e.g. by using proxy contracts or the diamond pattern:
https://dev.to/mudgen/ethereum-s-maximum-contract-size-limit-is-solved-with-the-diamond-standard-2189

Describe alternatives you've considered

Not sure where the best place is to put it... could make sense in a few places:

Additional context

More on the diamond pattern: https://eips.ethereum.org/EIPS/eip-2535

Want to contribute?

We love contributions from the Ethereum community! Please comment on an issue if you're interested in helping out with a PR.

@samajammin samajammin added feature ✨ This is enhancing something existing or creating something new content 🖋️ This involves copy additions or edits labels Sep 18, 2021
@samajammin
Copy link
Member Author

@mudgen let us know if you have thoughts on this 😄

@MrBrain295
Copy link
Contributor

@samajammin I could work on this.

@mudgen
Copy link

mudgen commented Sep 18, 2021

@mudgen let us know if you have thoughts on this smile

@samajammin I think it is a great idea to mention EIP-2535 anywhere the diamond pattern could help people.

@minimalsm
Copy link
Contributor

@MrBrain295 thanks for offering to help! I've assigned you 😬 you know the drill, any questions ask here or ping me.

minimalsm added a commit that referenced this issue Sep 21, 2021
Add info smart contact size limitations and diamond pattern
@minimalsm
Copy link
Contributor

Partially solved in #3957 but leaving this open for now as I still think it's a good idea to add more information about using proxy contracts.

@minimalsm minimalsm added good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help and removed feature ✨ This is enhancing something existing or creating something new labels Sep 21, 2021
@MrBrain295
Copy link
Contributor

I could take another blow at this.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Nov 19, 2021
@ossayed
Copy link

ossayed commented Jun 1, 2023

Hi there, I'd love to work on this issue! What information would you specifically like to be added more in depth beyond the change made perviously?

@corwintines
Copy link
Member

I think we can close this out from the previous PR from @MrBrain295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

No branches or pull requests

6 participants