-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info on smart contract size limit #3943
Comments
@mudgen let us know if you have thoughts on this 😄 |
@samajammin I could work on this. |
@samajammin I think it is a great idea to mention EIP-2535 anywhere the diamond pattern could help people. |
@MrBrain295 thanks for offering to help! I've assigned you 😬 you know the drill, any questions ask here or ping me. |
Add info smart contact size limitations and diamond pattern
Partially solved in #3957 but leaving this open for now as I still think it's a good idea to add more information about using proxy contracts. |
I could take another blow at this. |
This issue is stale because it has been open 45 days with no activity. |
Hi there, I'd love to work on this issue! What information would you specifically like to be added more in depth beyond the change made perviously? |
I think we can close this out from the previous PR from @MrBrain295 |
Is your feature request related to a problem? Please describe.
Currently we don't provide any info on this limitation.
Describe the solution you'd like
I think we should mention this contract size limitation (24KB) somewhere in our docs on smart contracts:
https://ethereum.org/en/developers/docs/smart-contracts/
We could also list approaches to getting around this limitation, e.g. by using proxy contracts or the diamond pattern:
https://dev.to/mudgen/ethereum-s-maximum-contract-size-limit-is-solved-with-the-diamond-standard-2189
Describe alternatives you've considered
Not sure where the best place is to put it... could make sense in a few places:
Additional context
More on the diamond pattern: https://eips.ethereum.org/EIPS/eip-2535
Want to contribute?
We love contributions from the Ethereum community! Please comment on an issue if you're interested in helping out with a PR.
The text was updated successfully, but these errors were encountered: