-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Pill
component with the Chakra Badge
component
#8551
Comments
I can work on this! A fun little project. |
Nice @TylerAPfledderer assigning it to you. Please take into account this bug that is related #8550 to this (in order to implement the correct color scheme in the badge theming). |
@pettinarip, correct. You got it! 👍 |
@pettinarip I notice that there are two styled pill components that do not use the Should I look to replace those or update them as well, even though the components they reside in have not been migrated yet? Most likely need to create a new child component within each given component to retain their logic. |
Good catch @TylerAPfledderer. If its possible yes, I would replace them since there is not going to be any conflict in using a Chakra component inside those components. |
@pettinarip this will impact
In addition, my continued observations show the StakingHierarchy component with a group of styled Pill-like elements, but the CSS selecting is a little more complex, as some of it is occurring at a section component. I will skip this and wait until this component is released into the second wave (and look to be assigned to it!) |
Got it @TylerAPfledderer. I'm assigning |
@pettinarip understood. Thank you! |
@pettinarip Created PR #8774 for this component. |
This issue is stale because it has been open 45 days with no activity. |
Is your feature request related to a problem? Please describe.
Currently we are using a custom component (
Pill
) to display a badge like component.Since we are migrating over using Chakra components, we need to replace this custom component with the Chakra one.
Describe the solution you'd like
Badge
component https://chakra-ui.com/docs/components/badge/usageBadge
component under https://github.com/ethereum/ethereum-org-website/tree/dev/src/%40chakra-ui/gatsby-plugin/componentsPill
componentPill
with theBadge
componentDescribe alternatives you've considered
None.
Additional context
No response
The text was updated successfully, but these errors were encountered: