Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement UI library - 2nd migration wave #8632

Closed
58 tasks done
Tracked by #6374
pettinarip opened this issue Nov 17, 2022 · 69 comments
Closed
58 tasks done
Tracked by #6374

Implement UI library - 2nd migration wave #8632

pettinarip opened this issue Nov 17, 2022 · 69 comments
Assignees
@pettinarip
Labels
archived: chakra-migration Status: In Progress Work is in progress

Comments

@pettinarip
Copy link
Member

pettinarip commented Nov 17, 2022 •
edited
Loading

This is part of our Implement UI library epic.

This is our 2nd list of components to migrate all of our UI components to Chakra.

How to contribute

If you’d like to help with this migration, please follow these steps:

  1. Leave a comment here asking which file you would want to work on.
  2. We assign you to the file (by adding your handle next to the file name in the list).
    • Read and follow our UI migration guide for some tips & guidance.
    • If you were assigned to multiple files then create a separate PR for each component. It will make the testing process much simpler and more organized.
  3. Once you finish it (PR merged), we’ll mark it as done.
  4. Repeat!

💡 Some of these components have some special requirements or considerations to take into account in the migration. Visit the issue attached to them to see the details.

Misc
@pettinarip pettinarip mentioned this issue Nov 17, 2022
Closed
80 tasks
@pettinarip pettinarip self-assigned this Nov 17, 2022
@pettinarip pettinarip changed the title Second wave [UI library] 2nd migration wave Nov 17, 2022
This was referenced Nov 17, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@TylerAPfledderer
Copy link
Contributor

TylerAPfledderer commented Nov 17, 2022 •
edited
Loading

@pettinarip I can take TableOfContents, StakingHomeTableOfContents, StakingHeirarchy, and ProductCard components, as I am assigned to current GH issues that involve these components. (Issues #8551 and #8552)

@MahendraBishnoi29
Copy link
Contributor

hey @pettinarip my 2 PRs are done now i want to work on MergeArticleList.tsx ShardChainsList.tsx SelectableCard.tsx 🚀🚀

@pettinarip
Copy link
Member Author

@TylerAPfledderer awesome 💪🏼 assigned! ty

@pettinarip
Copy link
Member Author

Assigned @MahendraBishnoi29! ty

I wanted to let you know that you still have DismissibleCard.tsx assigned to you from the 1st wave. Please, let me know if you are still considering in working on it or if I can reassign it to someone else.

@pettinarip pettinarip added the Status: In Progress Work is in progress label Nov 17, 2022
@pettinarip pettinarip changed the title [UI library] 2nd migration wave Implement UI library - 2nd migration wave Nov 17, 2022
@beamandala
Copy link
Contributor

Can I work on UpgradeArticles.tsx?

@pettinarip
Copy link
Member Author

Assigned @master7130, thanks!

@malunem
Copy link
Contributor

malunem commented Nov 17, 2022

Hi @pettinarip I'd like to work on a couple components! No preference 🙂

@pettinarip
Copy link
Member Author

👋🏼 @marcellamalune thanks. I've assigned ButtonDropdown.tsx & Codeblock.tsx to you.

@armgp
Copy link
Contributor

armgp commented Nov 17, 2022 •
edited
Loading

@pettinarip Hey can I work on Contributors.tsx and Layout.tsx

@TylerAPfledderer
Copy link
Contributor

TylerAPfledderer commented Nov 17, 2022 •
edited
Loading

@pettinarip Also assign to me StakingProductsCardGrid for the same reason as I stated above! (I promise I won't ask for any more unless absolutely necessary 😅 )

@TylerAPfledderer TylerAPfledderer mentioned this issue Nov 17, 2022
Merged
@pettinarip
Copy link
Member Author

@armgp done! & thanks

@pettinarip
Copy link
Member Author

@pettinarip Also assign to me StakingProductsCardGrid for the same reason as I stated above! (I promise I won't ask for any more unless absolutely necessary sweat_smile )

No worries :) thank you for being aware of those potential conflicts/dependencies.

@MahendraBishnoi29
Copy link
Contributor

Assigned @MahendraBishnoi29! ty

I wanted to let you know that you still have DismissibleCard.tsx assigned to you from the 1st wave. Please, let me know if you are still considering in working on it or if I can reassign it to someone else.

nope I'm working on it 💪🏻 also i think these are easy ones so i will complete them all so please assign me all these 😁🚀

@pettinarip
Copy link
Member Author

pettinarip commented Nov 18, 2022 •
edited
Loading

@MahendraBishnoi29 great! good to hear 🙌🏼

@frankiefab100
Copy link
Contributor

@pettinarip can I work on UpcomingEventsList.tsx

@Pranav-yadav

This comment was marked as outdated.

Sign in to view
@beamandala
Copy link
Contributor

@pettinarip Sorry for the delay. I'll have my PR ready in a couple days.

@pettinarip
Copy link
Member Author

Awesome @master7130 thanks!

@rishisundar
Copy link
Contributor

Hey, can I work on something? Don't have any preference. Would love to contribute!

@shariqanwar20
Copy link
Contributor

Hey @pettinarip is there anything I can contribute to. Would love to help

@pettinarip
Copy link
Member Author

@rishisundar @shariqanwar20 we've just created a new GH issue to start migrating the pages and templates. Check it out! #9353

@Seek4samurai
Copy link
Contributor

Hi @pettinarip can I work on UpgradeArticles.tsx? Let me know.

@hoanglamcoin hoanglamcoin mentioned this issue Feb 5, 2023
Closed
@pettinarip
Copy link
Member Author

Hey @Seek4samurai thanks for reaching out. That file is assigned to @master7130. @master7130 are you still interested in doing that migration? or can we assign it to @Seek4samurai ?

@Seek4samurai
Copy link
Contributor

Hey @Seek4samurai thanks for reaching out. That file is assigned to @master7130. @master7130 are you still interested in doing that migration? or can we assign it to @Seek4samurai ?

Um sadly I've started working over it. Though let me know about it. Thanks.

@malunem malunem mentioned this issue Feb 28, 2023
Closed
@TylerAPfledderer TylerAPfledderer mentioned this issue Mar 28, 2023
Merged
This was referenced Apr 12, 2023
Closed
Closed
@TylerAPfledderer
Copy link
Contributor

@pettinarip Could you go ahead and tag me for the WalletTable component? It looks like this one needs a major overhaul (table elements as rows inside a table element 😬 )

@pettinarip
Copy link
Member Author

Oh yea, that's a pretty big file.

table elements as rows inside a table element

Oh...didn't know about that! 😬

Thank you sir!

@pettinarip pettinarip mentioned this issue Apr 17, 2023
Closed
@TylerAPfledderer TylerAPfledderer mentioned this issue Apr 22, 2023
Merged
@TylerAPfledderer
Copy link
Contributor

@pettinarip commenting per our recent discussion to gain assignment for those listed under "Currently Blocked" to help get them over the finish line.

WalletTable already has an open PR to be marked (The reference directly above this comment ☝🏼 )

This was referenced May 12, 2023
Merged
Merged
@SouravInsights
Copy link

Hey, @pettinarip 👋 Is there still any components & pages that needs to be contributed? I can help out..

This was referenced May 15, 2023
Merged
Merged
@pettinarip pettinarip mentioned this issue May 24, 2023
Merged
This was referenced Jun 14, 2023
Merged
Merged
@pettinarip
Copy link
Member Author

🏄🏼‍♂️ wave 2 done!

@Seek4samurai
Copy link
Contributor

Hi @pettinarip, glad this is done! What's next for the Roadmap?

@pettinarip
Copy link
Member Author

Hi @Seek4samurai! thanks for all the work you put into this effort 🙌🏼

In terms of this epic, not much. I'll run some cleanup tasks to double-check that we are not using any styled and/or deprecated components.

In terms of UI, the idea is to keep working on DS implementation #9548 and implement necessary refactors as we create and implement new components/abstractions.

Finally, we are in the early stage of migrating our infra to NextJS. More info about this soon when we share our Q3 roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pettinarip pettinarip

Labels
archived: chakra-migration Status: In Progress Work is in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests