-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Migrate StakingHierarchy
to Chakra
#8686
Refactor: Migrate StakingHierarchy
to Chakra
#8686
Conversation
✅ ethereum-org-website-dev deploy preview ready
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @TylerAPfledderer
Just a few things I see comparing it with the prod version:
@pettinarip yikes! We have browser inconsistencies here. I definitely see this in Chrome, but the styling works as expected in Firefox. It also looks broken in prod on Chrome too, or maybe the other way around?? 🤔 Update: Applying 100% width to the wrapper for each eth glyph will fix the size inconsistency between browsers. They will be forced to the max width and in turn allow the vertical bars to connect between each glyph, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes @TylerAPfledderer.
I wouldn't say this is a blocker but I still see a small gap between the line and the eth logos. Probably it is related to the VStack
but I see you set it as gap={0}
in the md
breakpoint, so I'm not sure what is going on.
|
||
.gold { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to keep this class style since the markdown is using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add it back in and add a comment above it stating that markdown files use this classname
With For context and example, if .css-tnhm38 > :not(style) ~ :not(style) {
margin-top: 0.5rem;
}
|
@pettinarip should be good to go now! 😄 |
Oh got it. makes sense now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
Migrate the
StakingHierarchy
component to Chakra.Also includes updating the glyph icons to have
currentColor
as their fill values.Related Issue
#8632