-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(WalletTable): migrate to Chakra UI #10032
refactor(WalletTable): migrate to Chakra UI #10032
Conversation
✅ ethereum-org-website-dev deploy preview ready
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @TylerAPfledderer. Just found one tiny bug on mobile, gj. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TylerAPfledderer looking at this again, I see that we are only showing 1 column between md
and lg
. I think there is still space to display the 3 columns on md.
We should show 1 column below the md
breakpoint.
@pettinarip hmmm I see it in the deploy, and thought I would call out a Chakra bug with |
@pettinarip could you update this PR to get to the latest version of the 'develop' branch? I don't think it up-to-date with a bump of the Chakra version that should solve this. |
c25905b
to
c88e283
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @TylerAPfledderer. I see that the last issue was fixed after updating the chakra version 👍🏼
Description
Migrates the
WalletTable
component to Chakra UI. This PR also...WalletMoreInfo
component to its own fileRelated Issue
Closes #9982
Part of #8632