Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert translationLeaderboard to chakra #9058

Merged

Conversation

vdusart
Copy link
Contributor

@vdusart vdusart commented Jan 4, 2023

Description

Convert TranslationLeaderboard.tsx file to Chakra

Related Issue

Close: #8640
Epic: #8632

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jan 4, 2023

✅ ethereum-org-website-dev deploy preview ready

@vdusart vdusart changed the title Feat/convert translation leaderboard to chakra Convert translationLeaderboard to chakra Jan 5, 2023
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @vdusart. I've tested it and the component is working fine.

I've left a few small issues and an idea to refactor the buttons we are showing that I think are worth implementing.

src/components/TranslationLeaderboard.tsx Show resolved Hide resolved
src/components/TranslationLeaderboard.tsx Outdated Show resolved Hide resolved
src/components/TranslationLeaderboard.tsx Outdated Show resolved Hide resolved
src/components/TranslationLeaderboard.tsx Outdated Show resolved Hide resolved
src/components/TranslationLeaderboard.tsx Outdated Show resolved Hide resolved
src/components/TranslationLeaderboard.tsx Outdated Show resolved Hide resolved
src/components/TranslationLeaderboard.tsx Outdated Show resolved Hide resolved
@vdusart
Copy link
Contributor Author

vdusart commented Jan 18, 2023

Ok @pettinarip,
I just implemented the changes you proposed, tell me what you think about it 😄

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vdusart lgtm!

@pettinarip pettinarip merged commit 2a7db97 into ethereum:dev Jan 25, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Jan 25, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Ethereum.org Contributor:

GitPOAP: 2023 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@vdusart vdusart deleted the feat/convert-translationLeaderboard-to-Chakra branch January 25, 2023 17:33
@corwintines corwintines mentioned this pull request Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate TranslationLeaderboard.tsx to Chakra
2 participants