Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the DS v1 #9548

Open
30 of 34 tasks
pettinarip opened this issue Feb 22, 2023 · 8 comments
Open
30 of 34 tasks

Implementation of the DS v1 #9548

pettinarip opened this issue Feb 22, 2023 · 8 comments
Assignees
Labels
Status: In Progress Work is in progress Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@pettinarip
Copy link
Member

pettinarip commented Feb 22, 2023

This is part of our Implementation of the DS epic.

This issue will track the progress to implement the v1 of the DS.

How to contribute

If you’d like to help with this migration, please follow these steps:

  1. Leave a comment in any of the following unassigned tasks that interest you.
  2. We assign you to the task.
    • IMPORTANT: read and follow our DS implementation guide for some tips & guidance.
    • If you have any questions about the implementation of the given task, keep that conversation in the assigned issue or in the created PR.
  3. Once you finish it (PR merged), we mark it as done.
  4. Repeat!

Setup the foundation styles from the DS

Preview Give feedback
  1. TylerAPfledderer
  2. needs review 👀
    TylerAPfledderer

Base components - Button

Preview Give feedback
  1. corwintines
  2. TylerAPfledderer

Base components - Form components

Preview Give feedback
  1. content 🖋️ dependencies 📦 event 📅 needs review 👀 tooling 🔧 translation 🌍
    TylerAPfledderer

Base components - Tags

Preview Give feedback
  1. TylerAPfledderer
  2. TylerAPfledderer
  3. design system help wanted
    TylerAPfledderer

Base components - Navigation

Preview Give feedback
  1. TylerAPfledderer
  2. TylerAPfledderer
  3. Status: In Progress Status: Stale
    pettinarip
  4. Status: Stale
    pettinarip

Base components

Preview Give feedback
  1. TylerAPfledderer
  2. Status: Stale
    altinocoelho
  3. Status: Stale
    amit-ksh
  4. Status: Stale
    justynleung
  5. TylerAPfledderer
  6. TylerAPfledderer
  7. content 🖋️ needs review 👀
    TylerAPfledderer

Composed components

Preview Give feedback
  1. abandoned event 📅 needs review 👀
    TylerAPfledderer
  2. Status: Stale
    ashiskumar-1999
  3. Status: Stale
    pettinarip
  4. Status: Stale
    ameeetgaikwad
  5. amit-ksh
  6. TylerAPfledderer
  7. Status: Stale
    TylerAPfledderer

Layouts

Preview Give feedback

Issues/refactors

Preview Give feedback
  1. Status: Stale refactor ♻️
    pettinarip
@pettinarip pettinarip added the Status: In Progress Work is in progress label Feb 22, 2023
@pettinarip pettinarip self-assigned this Feb 22, 2023
@TylerAPfledderer
Copy link
Contributor

@pettinarip Noting here #9510 to help cover initial stages of the foundations.

@TylerAPfledderer
Copy link
Contributor

@pettinarip for the component themes, there is a certain direction I took in the CodeSandboxes.

These sandboxes are based on the latest version of Chakra where...

  1. New type-safety methods are used in the component theme configs
  2. The use of extendBaseTheme is applied so that the default themes for all the components in the package are NOT brought in immediately (which decreases payload bloat!)
  3. A certain approach in taken to import default theming where helpful and merge them with customized styles without unexpected overrides. And a component.utils.ts file was created in a couple of the sandboxes to add a custom merge function (retains it's own type safety) and a commonProps object where the styles are consistent between component types (See the Checkbox, Switch, and Radio components)

This means that Issue #8870 and PR #9577 become relevant here 👀

My question to you is your thoughts on the above. And if you are in favor with some are all of them, how you might want to go about "enforcing" the patterns as other contributors become involved in the effort.

@TylerAPfledderer
Copy link
Contributor

Create new textStyles

Now is this to be added in addition to setting theming configs for the Text and Heading components?

@pettinarip
Copy link
Member Author

@TylerAPfledderer thanks for pointing this out.

  1. Ok, sounds good
  2. Wow! I didn't know that. That is great. Looking forward to start using that
  3. Sounds fantastic and cleaner. Then, I guess that before (the current implementation), we were inheriting all the default styles for each component and that is why we needed to override a lot of other styles

I really like these patterns. I think they should have been there from the beginning but my ignorance was before.

When you say "enforcing the patterns", you are talking specifically about the style components we define for the Chakra components, right? If that is right, I support that, yes.

======

Now is this to be added in addition to setting theming configs for the Text and Heading components?

As discussed offline, we are not going to implement the textStyles and textLayers for this V1. For now, we are just going to style the Text and Heading component.

@TylerAPfledderer
Copy link
Contributor

@pettinarip Missing the Accordion on this list

@pettinarip
Copy link
Member Author

That is correct 😄 thanks for pointing that out, for some reason I missed also the Alerts and Tables 🤔...not sure what happened haha.

@ameeetgaikwad
Copy link
Contributor

If there is any issue, I would like to contribute!

Copy link
Contributor

github-actions bot commented May 9, 2024

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress Work is in progress Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

No branches or pull requests

3 participants