feat: added accordion for mobile nav #11686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameeetgaikwad
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @ameeetgaikwad! Appreciate your contribution here and apologies that this didn't end up progressing. When you posted this pretty much the whole dev crew on the team was all-hands-on-deck getting the site migrated to Next.js, and several PRs ended up piling up in the meantime; my apologies for that. I the meantime we had an epic that overhauled the menu navigation for the site on both desktop and mobile, which included the migration to using the Accordion component for the mobile. Given that, going to close this on out as it does not appear necessary anymore. Thank you again! |
github-actions
bot
added
the
abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
mobilecomponent to the new DS specificationsRelated Issue
Part of Implementation of new DS specifications
fixes #10751