Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button - Add multi-line support #10020

Closed
Tracked by #9548
pettinarip opened this issue Apr 20, 2023 · 6 comments · Fixed by #10315
Closed
Tracked by #9548

Button - Add multi-line support #10020

pettinarip opened this issue Apr 20, 2023 · 6 comments · Fixed by #10315
Assignees
@corwintines

Comments

@pettinarip
Copy link
Member

Description

Add styles on the button theme configuration to support multi-lines:
image

Resources
@pettinarip pettinarip mentioned this issue Apr 20, 2023
Open
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Apr 20, 2023
@pettinarip pettinarip removed the needs triage 📥 This issue needs triaged before being worked on label Apr 20, 2023
This was referenced Apr 20, 2023
Closed
Closed
@sumitshinde-84
Copy link

i would like to work on this issue @pettinarip

@pettinarip
Copy link
Member Author

Hi @sumitshinde-84! thanks for the help but this feature is already under development by @corwintines

@sumitshinde-84
Copy link

sumitshinde-84 commented May 2, 2023 •
edited
Loading

@pettinarip If you have any issues related to frontend, please feel free to let me know. I would be happy to assist you with any problems you may be experiencing

@TylerAPfledderer
Copy link
Contributor

@pettinarip @corwintines note that PR #10131 is created to introduce the Inter font to prod. Might not make a difference here, but when I checked the visual diff in Chromatic with the "demo" stories, it was showing a significant difference in character width from the font that was previously applied.

@TylerAPfledderer
Copy link
Contributor

@pettinarip @corwintines following up on this.

Working on updating the theming for Button, and wondering what has been done to resolve this feature?

@minimalsm minimalsm mentioned this issue Jun 2, 2023
Merged
@TylerAPfledderer TylerAPfledderer mentioned this issue Jun 9, 2023
Merged
@TylerAPfledderer
Copy link
Contributor

@corwintines @pettinarip this ended up being a part of the PR I did to update the variants. 😅

This was referenced Jul 11, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corwintines corwintines

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(theme/Button): implement new DS theming TylerAPfledderer/ethereum-org-website
5 participants
@pettinarip @corwintines @TylerAPfledderer @sumitshinde-84 and others