Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: overflowing text in a button on DAPPs page #9973

Closed
1 of 2 tasks
konopkja opened this issue Apr 17, 2023 · 9 comments
Closed
1 of 2 tasks

Bug report: overflowing text in a button on DAPPs page #9973

konopkja opened this issue Apr 17, 2023 · 9 comments
Assignees
Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing needs triage 📥 This issue needs triaged before being worked on

Comments

@konopkja
Copy link
Contributor

konopkja commented Apr 17, 2023

Describe the bug

text is overflowing on smaller browser sizes (tablet / mobile)

To reproduce

  1. Go to https://ethereum.org/en/dapps/
  2. Scroll down to 'Add dapp'
  3. See error (mobile / tablet)

Expected behavior

button text not overflowing, if necessary move button bellow on a new line (on mobile)

Screenshots

Screenshot 2023-04-17 at 17 38 37

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@konopkja konopkja added the bug 🐛 Something isn't working label Apr 17, 2023
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Apr 17, 2023
@konopkja konopkja added the good first issue Good item to try if you're new to contributing label Apr 17, 2023
@MukulKolpe
Copy link
Contributor

Hey @konopkja, can I work on this issue?

@konopkja
Copy link
Contributor Author

sure, thank you!

vaibhavtevatia added a commit to vaibhavtevatia/ethereum-org-website that referenced this issue May 5, 2023
vaibhavtevatia added a commit to vaibhavtevatia/ethereum-org-website that referenced this issue May 5, 2023
@vaibhavtevatia
Copy link

vaibhavtevatia commented May 5, 2023

Hi @konopkja, because of the inactivity on this issue. I've found the bug and fixed it.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jun 20, 2023
@konopkja
Copy link
Contributor Author

ping @corwintines

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jun 21, 2023
@ItIsOHM
Copy link

ItIsOHM commented Jul 3, 2023

Hey @konopkja is this issue still open? I'd like to give it a try :D

@konopkja
Copy link
Contributor Author

Hey @konopkja is this issue still open? I'd like to give it a try :D

Hello, there is a PR already to fix this. Just waiting for the review: #10141

This issue will be then closed. I suggest checking other open issues without linked PR firx.

ping @corwintines

@ItIsOHM
Copy link

ItIsOHM commented Jul 10, 2023

@konopkja Can you please suggest where I should look for some good first issues related to Ethereum? I can't find any new ones.

@minimalsm
Copy link
Contributor

This was solved as part of #10020. Closing this out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing needs triage 📥 This issue needs triaged before being worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants