Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug report: overflowing button text in stablecoins page #9784

Closed
konopkja opened this issue Mar 23, 2023 · 9 comments
Closed

Bug report: overflowing button text in stablecoins page #9784

konopkja opened this issue Mar 23, 2023 · 9 comments
Assignees
@MukulKolpe
Labels
bug 🐛 Something isn't working dev required This requires developer resources good first issue Good item to try if you're new to contributing Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@konopkja
Copy link
Contributor

konopkja commented Mar 23, 2023 •
edited
Loading

Describe the bug

  1. the text of the button is overflowing
  2. the colored background is too small, could be much wider so there is more space for the content inside

To reproduce

  1. Go to (https://ethereum.org/en/stablecoins/)
  2. Scroll down to "Use your stablecoins
  3. See error

Expected behavior

increase width of the components on mobile

Screenshots

Screenshot 2023-03-23 at 17 11 36

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response
@konopkja konopkja added bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing labels Mar 23, 2023
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Mar 23, 2023
@konopkja konopkja added dev required This requires developer resources and removed needs triage 📥 This issue needs triaged before being worked on labels Mar 23, 2023
@MukulKolpe
Copy link
Contributor

Hey @konopkja, can I work on this issue?

@konopkja
Copy link
Contributor Author

Hey @konopkja, can I work on this issue?

absolutely! assigned you the issue

@sanibalakrishna
Copy link

Hey @konopkja , If this issue is not resolved yet could you assign this issue to me?

@konopkja
Copy link
Contributor Author

Hey @konopkja , If this issue is not resolved yet could you assign this issue to me?

Hi @sanibalakrishna, let's give @MukulKolpe a few days to look at this since he asked first. Then I can reassign.

@MukulKolpe MukulKolpe mentioned this issue Mar 27, 2023
Closed
@MukulKolpe
Copy link
Contributor

@konopkja, @sanibalakrishna, sorry for the delay. I've raised a PR. Let me know if any changes are required.

@pettinarip
Copy link
Member

This needs to be fixed on the Button theme configuration. We have a design for this case in the Design System. I had made a new task under the DS implementation epic to keep track of it #10020

@minimalsm
Copy link
Contributor

Confirming I see this under 324px wide

@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jun 23, 2023
@konopkja
Copy link
Contributor Author

seems like this is fixed, so closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MukulKolpe MukulKolpe

Labels
bug 🐛 Something isn't working dev required This requires developer resources good first issue Good item to try if you're new to contributing Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed overflowing button text in stablecoins page MukulKolpe/ethereum-org-website
5 participants
@pettinarip @minimalsm @sanibalakrishna @MukulKolpe @konopkja