refactor: Bump Chakra-UI dep to latest #9577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies 📦
✅ ethereum-org-website-dev deploy preview ready
|
TylerAPfledderer
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
TylerAPfledderer
changed the title
pettinarip
approved these changes
Mar 6, 2023
| @@ -44,4 +44,5 @@ const theme: ThemeOverride = { | |||
| components, | |||
| } | |||
|
|
|||
| // TODO: use `extendBaseTheme` when updating theming for components for new DS | |||
There was a problem hiding this comment.
Whats the difference between extendBaseTheme vs extendTheme. Couldn't find it on the docs.
| @@ -127,7 +129,9 @@ | |||
| "serve": "gatsby serve", | |||
| "type-check": "tsc --noEmit", | |||
| "storybook": "storybook dev -p 6006 -c .storybook", | |||
| "build-storybook": "storybook build" | |||
| "build-storybook": "storybook build", | |||
| "theme": "chakra-cli tokens src/@chakra-ui/gatsby-plugin/theme.ts", | |||
There was a problem hiding this comment.
Nice. Interesting decision to place those generated types in node_modules and not on the project 🤔.
| ░░░░░░░░░▒▒▒▒▒▒▒▒▒▒▀▀░░░░░░░░ | ||
| </ContentColumn> | ||
| </Show> | ||
| <ContentColumn hideBelow={largeBp}> |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Recommend this PR for #9548 to not fall behind while implementing the DS. May need to consider timing in adding this while migrations are still ongoing
Description
This PR keeps Chakra up-to-date in preparation for the new DS
themeandtheme:watchto generate the typing and to generate the typing on watch when updating the theme config.postinstallpackage script to generate the typing when updating package deps or when a developer forks the project into their local environment for the first time.Show/Hidecomponents are replaced with thehideFromandhideBelowprops where possible.Related Issue
Closes #8870