Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extendBaseTheme instead of extendTheme #9679

Closed
Tracked by #9548
pettinarip opened this issue Mar 8, 2023 · 1 comment · Fixed by #9681
Closed
Tracked by #9548

Use extendBaseTheme instead of extendTheme #9679

pettinarip opened this issue Mar 8, 2023 · 1 comment · Fixed by #9681
Assignees

Comments

@pettinarip
Copy link
Member

With this approach, we apply the theme for just the components we need or those that we have defined in our custom theme. The main benefit is that this will reduce the amount of JS we bundle, resulting in improved performance.

As a consequence of this change, we’ll need to check and update all the existing component theme configs to ensure that they maintain the same styles and avoid any unexpected visual changes.

@TylerAPfledderer
Copy link
Contributor

@pettinarip have it assigned to me, please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants