Refactor: Migrate ProductCard to Chakra
#8685
Conversation
TylerAPfledderer
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
| @@ -156,7 +102,7 @@ export interface IProps { | |||
|
|
|||
| const ProductCard: React.FC<IProps> = ({ | |||
There was a problem hiding this comment.
There is a TODO regarding adding loading state. What is the desired loading visual?
There was a problem hiding this comment.
Hmm not sure 😆 wouldn't worry too much since that comment is 20 months old and probably we are going to refactor this with the DS.
✅ ethereum-org-website-dev deploy preview ready
|
There was a problem hiding this comment.
Nice @TylerAPfledderer
One small thing to look at. The pills/badges are not aligned:
| Img, | ||
| Text, | ||
| TextProps, | ||
| } from "@chakra-ui/react" |
There was a problem hiding this comment.
@pettinarip curious to know if ESLint has ever been considered with a config that includes import/order to enforce a specific order of the different import types?
There was a problem hiding this comment.
That would be a useful addition, yes. Hasn't been discussed/considered before AFAIK.
| } | ||
| } | ||
| return ( | ||
| <Box |
There was a problem hiding this comment.
These should be Badges in the upcoming refactor, right?
There was a problem hiding this comment.
@pettinarip Yes! I have made a note in #8601
| @@ -156,7 +102,7 @@ export interface IProps { | |||
|
|
|||
| const ProductCard: React.FC<IProps> = ({ | |||
There was a problem hiding this comment.
Hmm not sure 😆 wouldn't worry too much since that comment is 20 months old and probably we are going to refactor this with the DS.
Whoops, didn't see that! On it. |
src/components/ProductCard.tsx
Outdated
| {subjects && | ||
| subjects.map((subject, idx) => ( | ||
| <SubjectPill key={idx} subject={subject}> | ||
| {subject} | ||
| </SubjectPill> | ||
| ))} | ||
| {hasRepoData && | ||
| data.repository.languages.nodes.map( | ||
| data.repository.language.nodes.map( |
There was a problem hiding this comment.
Wondering why this has changed 🤔
Currently I see an error breaking some pages. These two pages are loading but breaking after a second:
Description
Migrate the
ProductCardcomponent to Chakra.Related Issue
#8632