-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Tabs to Chakra #8673
Migrate Tabs to Chakra #8673
Conversation
✅ ethereum-org-website-dev deploy preview ready
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @amit-ksh thanks for the PR.
I think the styles are correct for this but for the Tabs
case, we wanted to completely remove this component and start using the Chakra's Tabs instead. Declaring a new theme under https://github.com/ethereum/ethereum-org-website/tree/dev/src/%40chakra-ui/gatsby-plugin/components as it was described in the issue #8639
You can take as an example how we did this with the Button
component here https://github.com/ethereum/ethereum-org-website/blob/dev/src/%40chakra-ui/gatsby-plugin/components/Button.ts
LMK if you need help on defining the new variant for this case. I think we should override the enclosed
variant as it is pretty similar to our implementation.
Hey @pettinarip! I tried overriding the |
Yes @amit-ksh please, that sounds good. We can refactor the name later if we need to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 nice!
Description
Migrate the Tabs component from emotion to chakra
Related Issue
Closes #8639