Remove errored values from fee calculation #10353
Merged
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wackerow
requested review from
samajammin,
corwintines,
pettinarip,
minimalsm,
jmcook1186 and
nhsz
as code owners
github-actions
bot
added
content 🖋️
✅ ethereum-org-website-dev deploy preview ready
|
corwintines
approved these changes
May 30, 2023
This was referenced May 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note, this calculation still has issues with equal weighting of the networks (as opposed to weighting by TVL or tx volume), and the API results are only giving values for a few of the less utilized networks, which leads to a fairly misleading and inaccurate result here.
This PR simply patches the fact that
nullvalues were being included as "$0 fees", but does not address the other issues. As an alternative to this patch, I would also not be against removal of this metric until a more suitable API is investigated.Related Issue
From Discord