Adjust hero spacing on smaller screens #10379
Conversation
minimalsm
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
jmcook1186 and
nhsz
as code owners
src/components/PageHero.tsx
Outdated
| > | ||
| <Heading | ||
| as="h1" | ||
| textTransform="uppercase" | ||
| fontSize="md" | ||
| fontWeight="normal" | ||
| mt={{ base: "0px", lg: 8 }} |
There was a problem hiding this comment.
For some reason, base: 0 wasn't changing the base style at all here.
There was a problem hiding this comment.
Hmm I just tested it on my local and it worked as expected with base: 0 🤔
Sometimes the dev server does not update the components/styles automatically and you need to do a full refresh of the page.
Do you want to change it back to base: 0 and test it in the preview deploy? to discard that this is an issue with your local.
There was a problem hiding this comment.
Tried again local... same thing in all browsers 🤷♂️. Will update this PR and try in the preview deploy.
✅ ethereum-org-website-dev deploy preview ready
|
|
When we have images on top of the H1 should be some space.
|
…on smaller screens
@nloureiro fixed in this commit. Basically:
|
|
All good on my side, approved :) |
Description
Was messing around with @nloureiro in GH grooming and we made some small improvements to the PageHero's spacing on smaller screens, further changes will improve it on the DS implementation but this is a nice quick win.
Related Issue
None