Force /discord/ invite path links to full url #10397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wackerow
requested review from
samajammin,
corwintines,
pettinarip,
minimalsm,
jmcook1186 and
nhsz
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
minimalsm
previously approved these changes
Jun 8, 2023
There was a problem hiding this comment.
LGTM—working as expected now. Thanks @wackerow.
I do wonder if there is a more robust way of dealing with this,
If I understand the problem:
An internal link (e.g. /discord/) with a redirect to an external URL will always have this problem.
So this solves the problem for Discord links, but if we want to use this pattern in the future (e.g. we have ethereum.org/writing-cohort), we'll have to implement a fix for those cases too.
We don't need to invest time into this right now as it solves our immediate need.
|
@wackerow, I think we should pull this into staging for the release candidate. I've changed base branch to |
✅ ethereum-org-website-staging deploy preview ready
|
corwintines
approved these changes
Jun 8, 2023
This was referenced Jun 8, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/discord/to use the fullhttps://ethereum.org/discord/path. The former is being treated as an internal link and not triggering the desired redirect until a user refreshes the page at that path. By using the full path, it triggers the proper redirect for the Discord invite link.Linkcomponent to check for this relative path (/discord/) and update accordingly.Link, and then adjusting the string to the full path if it matches.Thank you to @megatheikal for reporting! And my apologies, this got brought up earlier while going through feedback as a team and I went ahead and put together a patch. It wasn't until now that I noticed your request to work on this, so I do apologize... Didn't mean to steamroll.
Preview link
https://ethereumorgwebsitedev01-discordinvite.gatsbyjs.io/en/contributing/translation-program/how-to-translate/#find-document -> Discord link
Related Issue