Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates "what is ethereum" page #10572

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Updates "what is ethereum" page #10572

merged 4 commits into from
Jun 29, 2023

Conversation

jmcook1186
Copy link
Contributor

@jmcook1186 jmcook1186 commented Jun 28, 2023

Description

Updates the learn/what-is-ethereum page by amending some copy and rearranging existing sections into a more logical order. Based on feedback that the current page wasn't adequately explaining the most important concepts. Also fixes unit error in one of the quiz questions.

Preview

https://ethereumorgwebsitedev01-whatisethereum.gatsbyjs.io/en/what-is-ethereum

@jmcook1186 jmcook1186 added content 🖋️ This involves copy additions or edits design All the issues related to design should use this tag labels Jun 28, 2023
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 28, 2023

✅ ethereum-org-website-dev deploy preview ready

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! This is looking a lot better... left a handful of small suggestions =)

src/intl/en/page-what-is-ethereum.json Outdated Show resolved Hide resolved
src/intl/en/page-what-is-ethereum.json Outdated Show resolved Hide resolved
src/intl/en/page-what-is-ethereum.json Outdated Show resolved Hide resolved
src/intl/en/page-what-is-ethereum.json Outdated Show resolved Hide resolved
src/intl/en/page-what-is-ethereum.json Outdated Show resolved Hide resolved
src/intl/en/page-what-is-ethereum.json Outdated Show resolved Hide resolved
src/intl/en/page-what-is-ethereum.json Outdated Show resolved Hide resolved
src/intl/en/page-what-is-ethereum.json Outdated Show resolved Hide resolved
src/intl/en/page-what-is-ethereum.json Outdated Show resolved Hide resolved
src/intl/en/page-what-is-ethereum.json Outdated Show resolved Hide resolved
Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @jmcook1186!

I have one suggestion to add here as well in addition to @wackerow. Overall, great though.

src/intl/en/page-what-is-ethereum.json Outdated Show resolved Hide resolved
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Corwin Smith <cssmittys@gmail.com>
@corwintines corwintines merged commit 850cf49 into dev Jun 29, 2023
@corwintines corwintines deleted the what-is-ethereum branch June 29, 2023 14:28
This was referenced Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits design All the issues related to design should use this tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants