Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix learn hub layout #10736

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix learn hub layout #10736

merged 1 commit into from
Jul 20, 2023

Conversation

pettinarip
Copy link
Member

Right now in the learn hub page we have a very narrow sidebar:
image

Description

This PR reuses the same layout components that we are using in the use-cases template to have a consistent layout between these pages. The use-cases template can be seen for example on the nft page.

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 20, 2023

✅ ethereum-org-website-dev deploy preview ready

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for putting up a fix Pablo ⚡

As this reduces the space for content a lot, I think we should either reduce the spacing in the grid or reduce the right margin of the table of contents (probably better):

Current:

Screenshot 2023-07-20 at 10 14 35

16px spacing:

Screenshot 2023-07-20 at 10 14 56

Reduced margin on toc:

Screenshot 2023-07-20 at 10 15 47

cc: @konopkja

@konopkja
Copy link
Contributor

the whole side navigation needs to have better UX, it has several flaws, one of them limiting the content on the right. A more comprehensive adjustments need to be in DS, I think @nloureiro may have looked into it or may not. But this would be good to prioritize too actually.

UX pains from my side to fix across the website:

  1. reduce margin between the two sections as @minimalsm described
  2. text in the sidebar aligned to the left, not right
  3. remove underline
  4. tweak sidebar text and headline sizes

@pettinarip
Copy link
Member Author

@minimalsm @konopkja Fair points. Mostly agreed with you on all of them.

This PR just fixes the current problem in the learn hub page and uses the shared layout that we are using in the rest of the layouts.

So, any change in spacing will impact all the other templates as well.

I'll merge this PR now as it is and then, my proposal is to discuss this with Nuno and implement those changes on the DS. If either of you have strong opinions and prefer to implement them now, I could implement them as well in a different PR. Probably the spacing one is the simplest one, let me know.

@pettinarip pettinarip merged commit 6393fb7 into dev Jul 20, 2023
@pettinarip pettinarip deleted the fix-learn-hub-layout branch July 20, 2023 16:43
This was referenced Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants