Fix icon of the edit button #10808
Merged
Fix icon of the edit button #10808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettinarip
requested review from
samajammin,
wackerow,
corwintines,
minimalsm,
jmcook1186 and
nhsz
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
|
Im wondering if we should be defaulting that hideArrow to true. There are many places that we use the ButtonLink for external links which now don't have the arrow (Layer 2 page, run a node page, staking pages, etc). |
|
Good point @corwintines. I think you are right. Let me revert that part. |
corwintines
approved these changes
Aug 9, 2023
This was referenced Aug 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify and use the new DS styles on the buttons with icons.
Description
Changes the color of the Edit button's icon to the primary color.
This PR also setshideArrowas always true in theButtonLinkas we never want to display the arrow for any link wrapped by this component.