Button - Fix disabled styles in solid variant #10859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettinarip
requested review from
samajammin,
wackerow,
corwintines,
minimalsm,
jmcook1186 and
nhsz
as code owners
pettinarip
force-pushed
the
button-disabled-styles
branch
from
ec2e93a to
f25d7ff
Compare
pettinarip
commented
Aug 3, 2023
| @@ -60,7 +60,7 @@ const semanticTokens = { | |||
| base: { _light: "white", _dark: "gray.700" }, | |||
| highlight: { _light: "gray.100", _dark: "gray.900" }, | |||
| }, | |||
| disabled: { _light: "gray.300", _dark: "gray.500" }, | |||
| disabled: { _light: "gray.400", _dark: "gray.500" }, | |||
There was a problem hiding this comment.
Updated this token to match the DS spec
✅ ethereum-org-website-dev deploy preview ready
|
minimalsm
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
LGTM as per design spec.
However, I think design should backlog revisiting this as it has contrast a11y issues.
cc: @nloureiro
This was referenced Aug 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the correct disabled styles to the button's solid variant as defined in the DS. It also shows the disabled state in the button's stories.