Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix image and link on /refi/ page #10912

Merged
merged 6 commits into from
Oct 15, 2023
Merged

fix image and link on /refi/ page #10912

merged 6 commits into from
Oct 15, 2023

Conversation

corwintines
Copy link
Member

Description

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 11, 2023

✅ ethereum-org-website-dev deploy preview ready

@nloureiro
Copy link
Contributor

Besides the fine-tuning of the image, should we add a caption to the image with credits? Where does this image come from?

@jmcook1186 probably, you can help on this one. 😀

@nloureiro
Copy link
Contributor

@corwintines I change the image to 450x450px, but on the dev preview it's not showing. Can you take a look?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

This has lost image quality when previewing, which may be related to pixel ratios. Do we need to downsize the image file or could we just put a max size on it when rendered?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since this is done through markdown, we might need to have it be 450px if that is our goal dimensions. Ill see if I can do this without losing quality.

@corwintines
Copy link
Member Author

I pushed a better res version of the 450x450px image. I think this is ready.

@wackerow wackerow merged commit 5f93847 into dev Oct 15, 2023
3 checks passed
@wackerow wackerow deleted the refiFixes branch October 15, 2023 17:17
This was referenced Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants