Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account


content: improved comprehensibility in the staking/pools page #10985

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

Fuliggine
Copy link
Contributor

Line 63: changed "that represents" to "and represent"

Description

Line 63 of the content/staking/pools page contains the sentence "Typically ERC-20 staking tokens are issued to stakers that represents the value of their staked ETH plus rewards". Replacing "that represents" with "and represent" improves comprehensibility.

Related Issue

None.

Line 63: changed "that represents" to "and represent".
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 23, 2023

✅ ethereum-org-website-dev deploy preview ready

@corwintines
Copy link
Member

Thanks @Fuliggine

I find this to be less clear than the original copy. Will ask for a second opinion.

@Fuliggine
Copy link
Contributor Author

Thank you for the review @corwintines :)

I proposed this change because the subject of the sentence is plural, while the verb is in the third person singular. I'm not a native English speaker though, so my interpretation could be wrong.

@corwintines
Copy link
Member

Thats a good point, I think you are right on second thought here. Thanks for the pushback on this, going to merge :)

@Fuliggine
Copy link
Contributor Author

Thank you very much! :)

@corwintines
Copy link
Member

@all-contributors can you add @Fuliggine for content

@allcontributors
Copy link
Contributor

@corwintines

I've put up a pull request to add @Fuliggine! 🎉

@corwintines corwintines merged commit 9575c04 into ethereum:dev Sep 6, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Sep 6, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2023 Ethereum.org Contributor:

GitPOAP: 2023 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

This was referenced Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants