Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding ChainLabo saas [Closes #10281] #10998

Merged
merged 5 commits into from
Oct 2, 2023
Merged

adding ChainLabo saas [Closes #10281] #10998

merged 5 commits into from
Oct 2, 2023

Conversation

natpicone
Copy link
Contributor

Adding ChainLabo SaaS provider

relates to #10281

@natpicone natpicone mentioned this pull request Aug 24, 2023
Closed
2 tasks
@wackerow wackerow changed the title adding ChainLabo saas #10281 adding ChainLabo saas [Closes #10281] Aug 24, 2023
wackerow
wackerow reviewed Aug 24, 2023
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @natpicone! Left a couple comments, otherwise this lgtm!

src/components/icons/staking/ChainLaboGlyphIcon.tsx Outdated Show resolved Hide resolved
src/data/staking-products.json Outdated Show resolved Hide resolved
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 24, 2023 •
edited
Loading

✅ ethereum-org-website-dev deploy preview ready

@natpicone natpicone requested a review from wackerow August 24, 2023 20:20
@natpicone
Copy link
Contributor Author

@wackerow can you please review and merge these changes? thx

wackerow
wackerow approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice job! Thanks @natpicone

@wackerow
Copy link
Member

Hey @natpicone, there is a merge conflict since other products have been added to this file since you mad your branch.... I tried to fix it but I think you've blocked any changes to your branch.

Can't merge with those there... Mind fixing the conflicts, or changing the settings so we can edit your branch? thanks!

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Sep 25, 2023
@natpicone
Copy link
Contributor Author

Hey @natpicone, there is a merge conflict since other products have been added to this file since you mad your branch.... I tried to fix it but I think you've blocked any changes to your branch.

Can't merge with those there... Mind fixing the conflicts, or changing the settings so we can edit your branch? thanks!

Hi @wackerow, the branch is updated and the merge conflict is resolved.
Tests are running, feel free to merge as they finish.
Thanks a lot.

@wackerow wackerow merged commit 8c3e665 into ethereum:dev Oct 2, 2023
4 checks passed
@gitpoap-bot
Copy link

gitpoap-bot bot commented Oct 2, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2023 Ethereum.org Contributor:

GitPOAP: 2023 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@wackerow
Copy link
Member

wackerow commented Oct 2, 2023

@all-contributors please add @natpicone for content

@allcontributors allcontributors bot mentioned this pull request Oct 2, 2023
Merged
@allcontributors
Copy link
Contributor

@wackerow

I've put up a pull request to add @natpicone! 🎉

@corwintines corwintines mentioned this pull request Oct 4, 2023
Merged
@corwintines corwintines mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow wackerow approved these changes

@samajammin samajammin Awaiting requested review from samajammin

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

@nhsz nhsz Awaiting requested review from nhsz

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natpicone @wackerow