-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gas page #11004
Add Gas page #11004
Conversation
✅ ethereum-org-website-dev deploy preview ready
|
@minimalsm on dark theme the summary box it's not changing background color |
@nloureiro yeah, it's an info banner—the same as here: https://ethereum.org/en/roadmap/scaling/ Should it not be an InfoBanner? |
Probably @pettinarip and @TylerAPfledderer haven´t updated this with a theme design token. for this PR leave it, might be fixed on a separate PR |
@minimalsm one more thing, the link on the menu. where should it be? |
Co-authored-by: Jakub <100724231+konopkja@users.noreply.github.com>
That component has not been adapted to use the DS styles yet. To clarify, the only components that use the DS styles are the ones that are defined in the DS figma file (or at least the ones that we have created so far). |
got it, Thank you for the clarification. I wasn´t sure if the colors were updated to the design system tokens and if the rest would be worked after. no worries all good |
Co-authored-by: Pablo Pettinari <pettinarip@gmail.com>
Co-authored-by: Pablo Pettinari <pettinarip@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes added @nloureiro @konopkja @pettinarip
Description