Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gas page #11004

Merged
merged 28 commits into from
Aug 29, 2023
Merged

Add Gas page #11004

merged 28 commits into from
Aug 29, 2023

Conversation

minimalsm
Copy link
Contributor

Description

  • Add learn page on gas

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Aug 25, 2023
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 25, 2023

✅ ethereum-org-website-dev deploy preview ready

@minimalsm minimalsm marked this pull request as ready for review August 28, 2023 12:04
@nloureiro
Copy link
Contributor

@minimalsm on dark theme the summary box it's not changing background color

Screen Shot 2023-08-29 09 08 46 AM

@minimalsm
Copy link
Contributor Author

@nloureiro yeah, it's an info banner—the same as here: https://ethereum.org/en/roadmap/scaling/

Should it not be an InfoBanner?
Or should InfoBanners based on theme?

@nloureiro
Copy link
Contributor

InfoBanners should follow the theme.

Probably @pettinarip and @TylerAPfledderer haven´t updated this with a theme design token.

for this PR leave it, might be fixed on a separate PR

@nloureiro
Copy link
Contributor

@minimalsm one more thing, the link on the menu.

where should it be?

Co-authored-by: Jakub <100724231+konopkja@users.noreply.github.com>
@pettinarip
Copy link
Member

InfoBanners should follow the theme.

Probably @pettinarip and @TylerAPfledderer haven´t updated this with a theme design token.

for this PR leave it, might be fixed on a separate PR

That component has not been adapted to use the DS styles yet.

To clarify, the only components that use the DS styles are the ones that are defined in the DS figma file (or at least the ones that we have created so far).

@nloureiro
Copy link
Contributor

got it, Thank you for the clarification.

I wasn´t sure if the colors were updated to the design system tokens and if the rest would be worked after.

no worries all good

Copy link
Contributor Author

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes added @nloureiro @konopkja @pettinarip

@minimalsm minimalsm merged commit 0eabe2f into dev Aug 29, 2023
@minimalsm minimalsm deleted the gasPage branch August 29, 2023 14:59
This was referenced Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants