Interactive simulator patches #11148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed from DemoOnlyPopover; updated to accept a `title` prop for a bolded header in the popover, and `content` for the contents of the popover. Added close button. Rolled out for various uses.
extend success display, convert "wallet" link to internal
wackerow
requested review from
samajammin,
corwintines,
pettinarip,
minimalsm,
jmcook1186 and
nhsz
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
|
@wackerow can we please in the first flow second step change headline from "They are free apps you can download" to "Wallets are free apps you can download" |
✅ ethereum-org-website-staging deploy preview ready
|
Co-authored-by: Pablo Pettinari <pettinarip@gmail.com>
corwintines
approved these changes
Sep 14, 2023
This was referenced Sep 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NotificationPopover(previously named DemoOnlyPopover) and further rolls out its usage with more helper textPreview URL