-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Figment to SaaS products [Closes #11160, Closes #12693] #11241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanszeftel To fit our theming, made some adjustments with the logo so let me know if this looks acceptable for you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanszeftel ^ Does this look okay?
Just noting the theming, black isn't used anywhere... if we just use the F it will kinda look like "F Figment", hence the approach above with a opacified background.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wackerow - stepping in for Ivan here as he is no longer at Figment. This logo looks all good, thank you!
"monthlyFee": 30, | ||
"monthlyFeeUnit": "% execution rewards", | ||
"isFoss": false, | ||
"hasBugBounty": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanszeftel As noted, this is from it being private
"hue": 52, | ||
"launchDate": "2021-12-31", | ||
"url": "https://figment.io/", | ||
"audits": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanszeftel As noted, this is from them not being publicly available
"isPermissionless": false, | ||
"pctMajorityExecutionClient": 85, | ||
"pctMajorityConsensusClient": 0, | ||
"isSelfCustody": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanszeftel As noted, this is from it being private
For safety reasons, the access to the validator private keys (signing keys) is strictly limited to the service.
"name": "Figment", | ||
"imageName": "Figment", | ||
"hue": 52, | ||
"launchDate": "2021-12-31", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanszeftel This won't end up affecting anything, since anything over 1 year is weighted the same, but you mentioned "mid 2021" which didn't let me zero it in on the exact date, so I just defaulted to the end of that year. Please feel free to update to proper date or more accurate month if you'd like; supporting evidence always appreciated =)
Hey @ivanszeftel, left a couple comments for you and just had a question to make sure the logo was okay since we adjusted to match site styling. I marked this PR as draft to at least allow you to take a peak and make sure this looks okay then we can bring it in. |
✅ ethereum-org-website-dev deploy preview ready
|
Hello @wackerow, What is the definition of execution diversity? I have some comments about the bug bounty and the audit, please let's hold on to publishing this until I come back with the details. Regarding the logo can we use this colour instead for the background #092B28 so it would look as the image attached? |
@ivanszeftel Execution diversity defined as: Will await bug bounty/audit information. The logo is tricky because of the theming on those pages... they're all monochromatic and don't use color. The backgrounds all use the same saturation/luminance, and only the hue is adjusted to give them a similar look/feel. cc: @nloureiro Any suggestions here? |
@ivanszeftel do you have a monochromatic version of the brand. Maybe just the F inside a square? I did find this on the staking event page, but it's your full logo. Should we use it? |
Hello @wackerow, Please find below Figment's updated response. Audit Penetration Testing Bug Bounty Client Diversity Self Custody Let me know if our updated response is clear enough to change the red for a green checkmark on Bug Bounty, Audited, and Client Diversity. Regarding the logo, we do have a monochromatic version, please find it attached. |
Although I appreciate the clear focus on security checks, the indicators listed for this site focus on the public availability of the reports that users can view. We're not currently set up to discern the validity or reputation of any certifications. For client diversity, if you keep things at at 50/50 split with some fluctuation, that seems reasonable to me to put 50% for these (I pushed a patch). Self Custody: This one is tricky because per our current definition the user would still not quite have full access to their keys, and would be reliant on the PSET. To my recollection, I thought these were dependent on the current fork of network upgrades, so if there is any chance the PSET would potentially not work for the user in the future, I'd want to make sure that's clear. ^ I raised a new issue (#11405) to further discussion on this. In the meantime I don't think we should adjust this too quickly, but if discussion supports I don't have a problem with updating and adjusting this listing. @ivanszeftel Let me know if you're comfortable with moving this forward or if you'd prefer to wait on discussion in the mentioned issue. |
Hey @ivanszeftel! Just circling back and touching base here... Let us know how you'd like to proceed, thanks! |
Hey @ivanszeftel, friendly ping on this. If we don't hear back we can close this out until further word |
Closing this out for now; @ivanszeftel please @ me if you decide you'd like to pursue this, thanks! |
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @wackerow - all good to proceed here and can switch it out of draft to "ready for review" - thanks! |
Hi, when reviewing the page noticed that "Figment" is not checked green for: could you please edit this as these should be green checks? The documentation was provided above in the request, but let me know if there is anything else I can provide |
Description
Related Issue